Skip to content

fix(api): resync sso provider schemas - #6058

Merged
Coly010 merged 1 commit into
supabase:developfrom
7ttp:fix/sso-list-domain-id
Aug 5, 2026
Merged

fix(api): resync sso provider schemas#6058
Coly010 merged 1 commit into
supabase:developfrom
7ttp:fix/sso-list-domain-id

Conversation

@7ttp

@7ttp 7ttp commented Aug 4, 2026

Copy link
Copy Markdown
Member

TL;DR

supabase sso list dies with SchemaError(Missing key at ["items"][0]["domains"][0]["id"])

The platform dropped id from saml and domains[] on the sso provider responses on Jul 21. Go absorbed it same day in #5897
we didn't, since our openapi.json still marks domains[].id required and we decode strictly.
show and update's preflight hit the same field, remove hits saml.id one earlier
they surface one at a time because decoding stops at the first missing key, which is why it reads like a regression of #5475.

The snapshot never healed because that same spec change tripped the two saml/required test ops in
openapi-overrides.json, the first sync run after the change, and api-package-sync has been red every run since
so this unblocks that too.
The two overrides go with it: upstream adopted both, there's nothing left to relax, and keeping them only re-arms the same hard stop next time.

Resynced the five schemas from the live spec and regenerated
byte-identical to a fresh pnpm generate, so the next sync won't fight it.
Nothing read the dropped fields, and sso.go-payload.ts already mirrored Go's struct without them, so -o yaml|toml is unchanged and -o json now drops them the way Go does, even if a project still echoes them.

Two things the resync pulled in that are worth naming rather than leaving for a reviewer to spot....
the attribute_mapping…default union flipped oneOfanyOf upstream, so the generated Schema.Union loses { mode: "oneOf" } — inert here, the four branches are disjoint so no value can match two.
And the fixture churn: the sso suites were feeding themselves saml.id/domains[].id that the API doesn't send,
so they'd have stayed green however stale the schema got. They use the real payload shape now....

refs

@7ttp
7ttp requested a review from a team as a code owner August 4, 2026 12:03
@7ttp 7ttp self-assigned this Aug 4, 2026
@Coly010
Coly010 added this pull request to the merge queue Aug 5, 2026
Merged via the queue into supabase:develop with commit a253ccb Aug 5, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

supabase sso list fails with SchemaError(Missing key at ["items"][0]["domains"][0]["id"])

2 participants